Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVX-292]: Fix Search Bugs #215

Merged
merged 3 commits into from
Nov 17, 2023
Merged

[DEVX-292]: Fix Search Bugs #215

merged 3 commits into from
Nov 17, 2023

Conversation

sainivedh
Copy link
Contributor

@sainivedh sainivedh commented Nov 16, 2023 •
edited
Loading

Why

  • current pagination listing doesn't stop at topk hits

What

  • Fix returning top_k hits in pagination
  • Fix input_dataset_ids filter for input_search

Tests

  • Updated existing tests to include (filter by dataset id, topk==1 for more than 1 inputs)

@sainivedh sainivedh marked this pull request as ready for review November 16, 2023 14:02
@sainivedh
Copy link
Contributor Author

sainivedh commented Nov 17, 2023 •
edited
Loading

@isaac-chung, Removed the max_top_k limit

isaac-chung
isaac-chung approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sainivedh sainivedh merged commit 2bcd2a0 into master Nov 17, 2023
@sainivedh sainivedh deleted the DEVX-292-fix-search-bugs branch November 17, 2023 10:50
@sainivedh sainivedh mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaac-chung isaac-chung isaac-chung approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sainivedh @isaac-chung