[DEVX-217] Cleanup Repo #211
Conversation
sainivedh
requested review from
sanjaychelliah,
ackizilkale and
sriram-clarifai
| @@ -28,24 +28,24 @@ class App(Lister, BaseClient): | |||
| """App is a class that provides access to Clarifai API endpoints related to App information.""" | |||
|
|
|||
| def __init__(self, | |||
| url_init: str = "", | |||
| url: str = "", | |||
| app_id: str = "", | |||
| base_url: str = "https://api.clarifai.com", | |||
There was a problem hiding this comment.
nit: Put this url into constants
There was a problem hiding this comment.
I assume you're referring to base_url?
There was a problem hiding this comment.
Will change this in a later PR
| | | Segmentation | `coco_segmentation` | | ||
| | | Captions | `coco_captions` | | ||
| |[xVIEW](http://xviewdataset.org/) | Detection | `xview_detection` | | ||
| | [ImageNet](https://www.image-net.org/) | Classification | `imagenet_classification` | | ||
| ## Contributing Modules |
There was a problem hiding this comment.
Suggestion: To avoid confusion with Clarifai's Modules, maybe we could use the name of the directory.
| ## Contributing Modules | |
| ## Contributing To Loaders |
| # note1: concept_name can be human readable | ||
| # note2: concept_id can only be alphanumeric, up to 32 characters, with no special chars except `-` and `_` |
There was a problem hiding this comment.
Nit: No need to enumerate notes.
| #convert mask to polygons and add to annots | ||
| contours, _ = cv2.findContours(mask, cv2.RETR_TREE, cv2.CHAIN_APPROX_SIMPLE) |
There was a problem hiding this comment.
Just found this, and is out of scope of this PR. Annotations support masks as base64 images: Annotation -> Data -> Image. How come we are converting them into polygons?
There was a problem hiding this comment.
For segmentation, only polygons are supported in dataloader
https://github.com/Clarifai/clarifai-python/blob/master/clarifai/datasets/upload/features.py
There was a problem hiding this comment.
Why is that, when we support seg masks?
There was a problem hiding this comment.
This is in todo planning, Need to extend the support for mask uploads.
What
Delete
clarifai.authas now langchain is updatedExamplesandLoaderswhich is available in clarifai-examples reposplitarg inupload_dataset()taskarg inupload_dataset()module_dirinupload_datasetRefactor
chunk_sizetobatch_sizein dataset/inputsurl_initarg name to urlClarifaiDataLoaderto includetaskpropertyclassestolabelsin all features to be consistentDATASET_UPLOAD_TYPESin constantsdataset_loaderto more usabledataloaderinupload_datasetbatch_sizeto 32 from 128text_clstask name to fulltext_classificationloaders