Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Input Filters in Search #204

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Conversation

sainivedh
Copy link
Contributor

@sainivedh sainivedh commented Nov 3, 2023

Why

  • Add support for PostInputsSearch

What

  • Supports Inputs Search by input_types, input_dataset_ids, input_status_code
# Get successful inputs of type imag, text
 from clarifai.client.search import Search
 search = Search(user_id='user_id', app_id='app_id', top_k=10, metric='cosine')
 res = search.query(filters=[{'input_types': ['image', 'text']}, {'input_status_code': 30000}])

Tests

  • Added unit tests for the same

@sainivedh sainivedh marked this pull request as ready for review November 3, 2023 08:19
Copy link
Contributor

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to make sure the tests pass.

@sainivedh
Copy link
Contributor Author

Looks good, just need to make sure the tests pass.

Looks like it's related to DeleteInputs endpoint failure.
https://clarifai.slack.com/archives/C042HEJASG0/p1699258480392629

@sainivedh sainivedh requested a review from isaac-chung November 6, 2023 17:38
@sainivedh sainivedh merged commit f8ebe13 into master Nov 6, 2023
@sainivedh sainivedh deleted the isaac/support-input-filters branch November 6, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants