Skip to content

Base url #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 26, 2023
Merged

Base url #176

merged 4 commits into from
Sep 26, 2023
+67 −39

Conversation

sanjaychelliah
Copy link
Contributor

what

  • passing base_URL feature in SDK

sainivedh
sainivedh approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@sainivedh sainivedh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Can you also edit Doc String

@sanjaychelliah sanjaychelliah merged commit 293794b into master Sep 26, 2023
@sanjaychelliah sanjaychelliah deleted the Base_URL branch September 26, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainivedh sainivedh sainivedh approved these changes

@ackizilkale ackizilkale Awaiting requested review from ackizilkale

@josh-tepper josh-tepper Awaiting requested review from josh-tepper

@sriram-clarifai sriram-clarifai Awaiting requested review from sriram-clarifai

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanjaychelliah @sainivedh