[DEVX-197]: Add Runners Interface #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainivedh
changed the title
sainivedh
requested review from
zeiler,
ackizilkale,
josh-tepper,
sanjaychelliah and
sriram-clarifai
zeiler
requested changes
Sep 6, 2023
clarifai/client/app.py
Outdated
|
|
||
| Example: | ||
| >>> from clarifai.client.app import App | ||
| >>> app = App(app_id="app_id", user_id="user_id") |
There was a problem hiding this comment.
runners are actually not owned apps like other resources, they are owned by the user/org (like a sibling to apps). This is how github does it and in the future we can add runner groups like github has to limits runners to certain apps if needed. So for the API client the runners should be off the User object instead of App.
There was a problem hiding this comment.
Got it. Now changed to User object instead of App.
zeiler
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Restructure and add Runners Interface from Utils
Added create, search, delete, list of runner objects
Tests