[EAGLE-3230] [EAGLE-3452] Create tests users can run for triton model upload and fix error in python 3.11 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackizilkale
reviewed
Aug 30, 2023
ackizilkale
reviewed
Aug 30, 2023
ackizilkale
reviewed
Aug 30, 2023
ackizilkale
reviewed
Aug 30, 2023
ackizilkale
reviewed
Aug 30, 2023
deigen
reviewed
Sep 1, 2023
| f"`labels.txt` is empty!. Model type `{self.model_type}` requires input labels in `labels.txt`" | ||
| ) | ||
|
|
||
| def test_inference_with_predefined_inputs(self): |
There was a problem hiding this comment.
This is a good test, but I think it may be difficult for the user to debug, for two reasons:
- it's in a library class, not the test file visible to the user, so when it fails they may need to look at the package code to debug
- it's cased with lots of input types other than the one that user is using, making most of the code irrelevant to their model
Another option could be to create a different test class with this test function for each model type, in separate files. Then when generating the test repo, copy the class for the model type into the test module, so the test code is easily visible and editable (may or may not want to do this second part depending on what it looks like).
Not needed to merge, we could change that later if needed.
There was a problem hiding this comment.
Thank you for your suggestions. I believe users can follow the messages in the test and fix their inference code because it has messages for individual assertions.
phatvo9
changed the title
ackizilkale
approved these changes
Sep 6, 2023
HarmitMinhas96
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How