Don't pass 'default' model #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,7 +136,7 @@ def __init__(self, app_id=None, app_secret=None, base_url='https://api.clarifai. | |||
| self.api_info = None | |||
|
|
|||
| def set_model(self, model): | |||
| self._model = self._sanitize_param(model, 'default') | |||
| self._model = self._sanitize_param(model) | |||
There was a problem hiding this comment.
If I read the current code right, we're already not sending an explicit model param in the default case. self._model is None, and _sanitize_param returns None when it gets None. I think this change isn't necessary.
There was a problem hiding this comment.
Yeah you're right. Either way, we still shouldn't convert the error to 'default'.
There was a problem hiding this comment.
I think just letting the unicode error get raised is appropriate.
josh-tepper
pushed a commit
that referenced
this pull request
Aug 11, 2023
* Added model generator for util lister; bumped version to 0.1.16 from 0.1.15 * added in option to only return models created within app, not all accessible models * linting * Linter * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.