-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVX:123] Support Dataset Upload #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just minor comments..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Is the upload sub directory under datasets necessary? (clarifai.datasets.upload
).
If not , I think we can reduce the nesting and move the files to under datasets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as the outstanding conversations are resolved.
only the one comment on changing this notion of zoo to more of what it seems that folder is which is just different types of loaders of datasets. I didn't do a thorough code review as there are many eyes on it overall. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Dataset Upload Functionality in SDK
What
This enhancement introduces dataset upload functionality to the Clarifai SDK, leveraging the existing Python utility data upload approach.
How
To utilize this new functionality, users can follow these steps:
Improvements
ClarifaiDataLoader
classTests
Manual data upload test for