Makefile is broken on osx with zsh

[patcon]

Expected behavior:
For make build on edge branch to build successfully

Actual behavior:
I get this error:

$ make build
ENV_FILE=.env
POSTGRES_DOCKER= true
TAG= dev
docker compose -f docker-compose.yml -f docker-compose.dev.yml --profile postgres --env-file .env build
[+] Building 0.0s (0/0)                                                                                                                                                                       docker:colima
invalid tag "docker.io/compdem/polis-postgres:\tdev": invalid reference format
make: *** [build] Error 17

To Reproduce:
Git clone and run make build or make echo_vars

Note the tabs "\t" in the output, and the whitespace in the vars

Screenshots:

Device information:
Current environment:

• OSX Sonoma 14.5
• zsh 5.9 (x86_64-apple-darwin23.0)
• colima version 0.7.5 (alternative docker-compat container runtime)
  • this is the only "weird" thing, but I isolated a fix in the makefile environmen
• Docker version 27.2.1, build 9e34c9bb39
• Docker Compose version 2.29.2
• GNU Make 3.81

Additional context:
None

Solution

I've found a fix that I will share shortly. Basically, issue involves make format, the define method, and whitespace in a place that make doesn't like it :)

[patcon]

oi, took like an hour to figure out and zero in, but the very tiny fix is in #34 😅

cc @ballPointPenguin to get it cherry-picked into upstream. Godspeed, human!

$ git remote add patcon [email protected]:patcon/polis.git
$ git fetch patcon
$ git checkout -b makefile-build-error
$ git cherry-pick e2438334

(For others: Doing this round-about workflow, because for complicated and unrelated reasons, I'm unable to report the bug or submit the PR to the upstream compdem repo on my own)

[ballPointPenguin]

good catch. Makefile tabs-vs-spaces strikes again.

[ballPointPenguin]

merged compdemocracy#1822