Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the jsonb column type #41

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Using the jsonb column type #41

merged 1 commit into from
Feb 21, 2019

Conversation

thekaveman
Copy link
Contributor

This corresponds with changes in CityofSantaMonica/mds-provider-services#12

@hunterowens
Copy link
Collaborator

@thekaveman effects on implementation? / Migration path?

@thekaveman
Copy link
Contributor Author

Migration should be straight-forward, see https://github.com/CityofSantaMonica/mds-provider-services/blob/db/db/migrate/0.2.0.sql.

Everything I've been reading says there are only very limited use-cases for using a json column type (e.g. if you absolutely need to preserve whitespace or key order for some reason). jsonb is more performant, it is indexable, and has some interesting query capabilities not available in json. The Postgres JSON Types doc has a pretty good write-up.

There could be a slight performance hit on writing new data, as there is some work done to format text into jsonb.

@hunterowens
Copy link
Collaborator

Thanks. I have to make corresponding changes into aqueduct for migrations, not super hard but good to have reference implementation.

@thekaveman thekaveman changed the base branch from master to dev November 19, 2018 19:39
@thekaveman thekaveman changed the base branch from dev to master December 31, 2018 19:23
@thekaveman thekaveman added this to the MDS 0.3.0 milestone Feb 12, 2019
@thekaveman thekaveman changed the base branch from master to mds-0.3 February 21, 2019 21:10
@thekaveman thekaveman changed the base branch from mds-0.3 to master February 21, 2019 21:12
@thekaveman thekaveman changed the base branch from master to mds-0.3 February 21, 2019 21:12
@thekaveman thekaveman merged commit 731d447 into mds-0.3 Feb 21, 2019
@thekaveman thekaveman deleted the db branch February 21, 2019 21:15
thekaveman added a commit that referenced this pull request Apr 23, 2019
thekaveman added a commit that referenced this pull request Apr 24, 2019
thekaveman added a commit that referenced this pull request Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants