Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accessibility fixes on header #2115

Merged
merged 2 commits into from
Apr 10, 2024
Merged

fix: Accessibility fixes on header #2115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82c8e5d
Merge pull request #2113 from CityOfPhiladelphia/search-titles-fix
m-atia Apr 9, 2024
12744c7
add aria label to menu items that were not labelled
m-atia Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions wp/wp-content/themes/phila.gov-theme/header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@
<li class="show-for-medium"><a id="translate-chinese" href="<?php echo inject_translation_slug('zh'); ?>">中文</a></li>
<?php endif; ?>
<!-- Dropdown button -->
<button translate="no" class="translations-button show-for-medium" id="desktop-lang-button" data-toggle="lang-dropdown">
<button aria-label="Language dropdown" translate="no" class="translations-button show-for-medium" id="desktop-lang-button" data-toggle="lang-dropdown">
<i class="fa fa-earth-americas"></i>
<i class="translate-caret fas fa-solid fa-caret-down"></i>
</button>
<button class="translations-button show-for-small-only" id="mobile-lang-button" data-toggle="lang-dropdown">
<button aria-label="Mobile language dropdown" class="translations-button show-for-small-only" id="mobile-lang-button" data-toggle="lang-dropdown">
<i class="fa fa-earth-americas"></i>
<a tabindex="-1" class="show-for-small-only" href="#">Translate</a>
<i class="translate-caret fas fa-solid fa-caret-down"></i>
Expand Down Expand Up @@ -157,7 +157,7 @@
<div class="columns phila-sticky phn" data-margin-top="0" data-sticky data-sticky-on="medium">
<div class="row sticky-header-width">
<div class="small-4 columns menu-icon-container" data-responsive-toggle="mobile-nav" data-swiftype-index="false" data-hide-for="medium">
<button class="menu-icon" type="button" data-toggle>
<button aria-label="Mobile navigation menu" class="menu-icon" type="button" data-toggle>
<i class="fass fa-bars" aria-hidden="true"></i>
</button>
</div>
Expand All @@ -168,7 +168,7 @@
</div>
<div class="medium-16 columns pan show-for-medium desktop-nav">
<div class="top-bar-right">
<nav data-swiftype-index="false" class="global-nav" aria-label="main-nav">
<nav data-swiftype-index="false" class="global-nav" aria-label="Main navigation menu">
<ul class="menu">
<li class="services-menu-link" data-toggle="services-mega-menu">
<a href="" class="no-link " data-link="/services/" onclick="noLink(event)">Services</a>
Expand All @@ -193,7 +193,7 @@
</div>
</div>
<div class="small-4 medium-1 columns phn-m prn site-search-container">
<button id="site-search-button" class="site-search" type="button" data-toggle="search-dropdown">
<button aria-label="Site search" id="site-search-button" class="site-search" type="button" data-toggle="search-dropdown">
<i class="fass fa-magnifying-glass" aria-hidden="true"></i>
</button>
</div>
Expand Down