-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove access_token hiding hack from helusername backend #161
Conversation
This hack worked around a weirdness with Keycloak access token. It is not needed anymore and is broken anyway with newer pysocial(?).
Codecov Report
@@ Coverage Diff @@
## develop #161 +/- ##
===========================================
+ Coverage 86.10% 86.11% +0.01%
===========================================
Files 150 150
Lines 5576 5574 -2
===========================================
- Hits 4801 4800 -1
+ Misses 775 774 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the python-jose version be set in the requirements.in and running pip-compile?
Like so:
python-jose>=3.2.0
Well, it is a transitive dependency. I'm hoping social-core will get back into business and update their dependencies. At least the project recently got a new maintainer. |
Yes I know. But if it's our need that the version should be newer, we should maybe set it in our requirements? |
Btw. python-jose 3.2.0 brings other updates that are not now in the requirements.txt. |
Fair enough. I'll push the changes to requirements.in |
fa3fe97
to
4b2dbb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Remove a hack to work around a bug in python-jose and upgrade to a fixed version of python-jose.
Keycloak 9.x issued ID-tokens without at_hash claim during authorization code flow. This caused the buggy library to reject the token. See mpdavis/python-jose#75
Newer versions of Keycloak started to include the claim even during authorization code flow, which masked the bug.