Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Search Input as core component #345

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Conversation

aleksik
Copy link
Contributor

@aleksik aleksik commented Dec 21, 2020

Description

This PR implements the Search input as a core component.

How Has This Been Tested?

Tested locally in storybook.

@aleksik aleksik requested a review from ronijaakkola December 21, 2020 13:13
@aleksik aleksik added the component New component request. Issues labeled as components will show in the project roadmap. label Dec 21, 2020
Copy link
Contributor

@ronijaakkola ronijaakkola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via staging Storybook and it seems to be working similarly to the React version.

Tested with VoiceOver and NVDA screen readers.

@ronijaakkola ronijaakkola added the waiting-for-accessibility-audit Issue or request is waiting for an accessibility audit. label Jan 7, 2021
@ronijaakkola ronijaakkola removed the waiting-for-accessibility-audit Issue or request is waiting for an accessibility audit. label Jan 18, 2021
@ronijaakkola
Copy link
Contributor

This has also been audited now. Ready to be merged and released.

@aleksik aleksik merged commit 0c41853 into master Jan 19, 2021
@aleksik aleksik deleted the feature/search-input-core branch January 19, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component New component request. Issues labeled as components will show in the project roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants