Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Koros as core components #318

Merged
merged 5 commits into from
Nov 24, 2020
Merged

[Feature] Koros as core components #318

merged 5 commits into from
Nov 24, 2020

Conversation

aleksik
Copy link
Contributor

@aleksik aleksik commented Nov 16, 2020 •
edited
Loading

Description

This PR implements Koros as core components.

How Has This Been Tested?

Tested locally in Storybook

Demo

Stories in staging

@aleksik aleksik requested a review from ronijaakkola November 16, 2020 13:50
@aleksik aleksik added the component New component request. Issues labeled as components will show in the project roadmap. label Nov 16, 2020
ronijaakkola
ronijaakkola reviewed Nov 17, 2020
View reviewed changes
packages/core/src/components/koros/koros.stories.js Outdated
</div>
`;

export const Storm = () => `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huomasin, että nämä storyt ovat Reactin ja Coren Storybookissa hieman eri tavalla nimetty ja eri järjestyksessä. En tiedä onko tällä kamalasti merkitystä, mutta jos tuolle ei ole erityistä syytä, niin ne voisi yhtenäistää. Samat kirjoitusasut ja samassa järjestyksessä siltä osin kuin ovat samaa tavaraa.

Esim. "Horizontally flipped" vs "Flipped", Reactista puuttuu "Custom color" kokonaan, muodot ovat hieman eri järjestyksessä (voisi seurata vaikka dokumentaatiosivun ja Sketchin järjestystä basic, beat, pulse ,wave, storm).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyvä huomio!

Päivitin storyt yhtenäisiksi kirjoitusasun ja järjestyksen osalta. Lisäsin myös reactin puolelle "Custom color" -storyn.

ronijaakkola
ronijaakkola suggested changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@ronijaakkola ronijaakkola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lisäsin ylle pienen korjausehdotuksen Storybookin storyihin.

@ronijaakkola
Copy link
Contributor

Päivitän dokumentaation tähän branchiin myös.

@aleksik aleksik requested a review from ronijaakkola November 17, 2020 13:40
@aleksik aleksik merged commit a19b5c1 into master Nov 24, 2020
@aleksik aleksik deleted the feature/core-koros branch November 24, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronijaakkola ronijaakkola ronijaakkola approved these changes

Assignees
No one assigned
Labels
component New component request. Issues labeled as components will show in the project roadmap.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksik @ronijaakkola