[Accessibility] Add warning for non-string checkbox labels #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds warning when using other than strings as a checkbox label.
Motivation and Context
Links (anchor) embedded in label is poor usability and accessibility practice:
First, it is very easy for keyboard and screenreader users to accidentally activate the link and/or the checkbox when attempting to click the other one, as users do not necessarily perceive the elements as separate. Secondly, such an unorthodox tag embedding will cause some screenreaders to describe the embedded link in a very unusual manner that is hard to comprehend.
We recommend that the link be rather placed adjacent but separate to the checkbox. E.g. first the link “City data protection principles”, and below it as a separate checkbox: I have read the city data protection principles (link above).”
Related Issue
#140