Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement Footer #253

Merged
merged 24 commits into from
Oct 12, 2020
Merged

[Feature] Implement Footer #253

merged 24 commits into from
Oct 12, 2020

Conversation

niglu1
Copy link
Contributor

@niglu1 niglu1 commented Sep 18, 2020

Description

This includes the implementation for the Footer component.

  • The component consists of the main Footer component and the following subcomponents:
    • FooterNavigation
    • FooterItemGroup
    • FooterItem
    • FooterUtilities
    • FooterSoMe
    • FooterBase
  • Created helper functions for duplicate code
  • Styles are done using SASS
  • Added @storybook/addon-controls and wrote the footer stories using Args

Closes #172

How Has This Been Tested?

On Storybook and a test app using the local react package as a dependency

@niglu1 niglu1 requested a review from lehtoinen September 18, 2020 06:42
@niglu1 niglu1 marked this pull request as ready for review September 21, 2020 14:58
@niglu1 niglu1 merged commit caab7d6 into master Oct 12, 2020
@niglu1 niglu1 deleted the feature/implement-footer branch October 12, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer
4 participants