Fix serialized big data issue #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now single object can be more than 500MB because of cap'n protocol limitation, according to author, it should be List(List(Data)) then concatenate them should support the bytes more than 500MB, but pycapnp is not supporting memoryview now, so when splitting and concatenation, it will create multiple copy for sure, but it should be done right after serialization and deserialization stage and release the memory, - later when we moved from pyzmq to pynng, the memory copy issue should get easied because pynng will expose more raw operations, and we can save threads Signed-off-by: Sharpner6 <[email protected]>
|
@rafa-be, please review this, if approved, please merge and create release, thanks |
rafa-be
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now single object can be more than 500MB because of cap'n protocol limitation, according to author, it should be List(List(Data)) then concatenate them should support the bytes more than 500MB, but pycapnp is not supporting memoryview now, so when splitting and concatenation, it will create multiple copy for sure, but it should be done right after serialization and deserialization stage and release the memory,
later when we moved from pyzmq to pynng, the memory copy issue should get easied because pynng will expose more raw operations, and we can save threads