Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of copy memory when receive and send message #34

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

sharpener6
Copy link
Collaborator

Hopefully this will use zero copy, but it's rely on pyZMQ's implementation, if this still doesn't solve copy problem (should use zero copy), we will need implement c/c++ version of client agent + scheduler + worker agent.

@sharpener6 sharpener6 requested a review from rafa-be October 12, 2024 14:56
rafa-be
rafa-be previously approved these changes Oct 14, 2024
Copy link
Collaborator

@rafa-be rafa-be left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you noticed any improvement in performances?

rafa-be
rafa-be previously approved these changes Oct 16, 2024
@sharpener6 sharpener6 merged commit f3b6cf4 into Citi:main Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants