Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added check if ip info is ipaddress object #91

Closed
wants to merge 2 commits into from
Closed

added check if ip info is ipaddress object #91

wants to merge 2 commits into from

Conversation

tahigash
Copy link
Collaborator 

    ip = self.connection_info.ip.exploded
AttributeError: 'str' object has no attribute 'exploded'

User reported seeing above error in case user creates testbed object in python instead of loading testbed yaml.

So, I added a check to if ip info is ipaddress object or not. if not, use it as is.

@tahigash tahigash requested a review from a team as a code owner September 21, 2022 20:44
@dwapstra
Copy link
Contributor

dwapstra commented Jun 8, 2023

Superseded by #108

@dwapstra dwapstra closed this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GerriorL GerriorL GerriorL approved these changes

@bastell bastell Awaiting requested review from bastell bastell was automatically assigned from CiscoTestAutomation/pyats-genie-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tahigash @dwapstra @GerriorL