Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOS-XR] Fix show l2vpn bridge-domain detail : Parses variations in the EVI field format correctly #907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kani999
Copy link
Contributor

@Kani999 Kani999 commented Oct 29, 2024

  • Modified p63 regex in show_l2vpn.py to support optional suffix (e.g., "(SRv6)") for EVI values
  • Updated golden9_expected.py to reflect new test output for EVI field
  • Adjusted URL in github_parser.json for the updated line reference

These changes enhance the parser's compatibility with new formats in ShowL2vpnBridgeDomainDetail.

Description

The ShowL2vpnBridgeDomainDetail parser for IOS-XR devices was not handling some variations in the EVI field format correctly, resulting in parsing errors or missed data. Specifically, when the evi field includes additional suffix information (e.g., (SRv6)), the parser could not match this pattern and failed to extract the EVI value.

Motivation and Context

  • Support optional suffix (e.g., "(SRv6)") for EVI values

Closes #906

Checklist:

  • I have updated the changelog.
  • I have updated the documentation (If applicable).
  • I have added tests to cover my changes (If applicable).
  • All new and existing tests passed.
  • All new code passed compilation.

@Kani999 Kani999 requested a review from a team as a code owner October 29, 2024 09:54
@Kani999 Kani999 requested review from lsheikal and omehrabi October 29, 2024 09:54
@Kani999 Kani999 force-pushed the fix_evi_show_l2vpn_bridge_domain_detail branch from 1fae532 to afd0682 Compare October 29, 2024 10:00
@Kani999

This comment was marked as resolved.

…ail parser

- Modified `p63` regex in `show_l2vpn.py` to support optional suffix (e.g., "(SRv6)") for EVI values
- Updated `golden9_expected.py` to reflect new test output for EVI field
- Adjusted URL in `github_parser.json` for the updated line reference

These changes enhance the parser's compatibility with new formats in `ShowL2vpnBridgeDomainDetail`.
@Kani999 Kani999 force-pushed the fix_evi_show_l2vpn_bridge_domain_detail branch from afd0682 to 9aa193c Compare December 2, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IOS-XR] Parsing Incompatibility for show l2vpn bridge-domain detail Command Output
1 participant