added priority percent to show policy map for iosxe #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mc4leaf, I have left few comments to improve your PR. Along with those, kindly add unit tests as well such as mentioned in this directory: https://github.com/CiscoTestAutomation/genieparser/tree/master/src/genie/libs/parser/iosxe/tests/ShowPolicyMap/cli/equal Kindly let me know if you have any questions. Thank you. |
SohanTirpude
reviewed
Dec 6, 2023
changelog/undistributed/changelog_show_policy_map_iosxe_20231127192427.rst
Outdated
Show resolved
Hide resolved
src/genie/libs/parser/iosxe/tests/ShowPolicyMap/cli/equal/golden_output16_expected.py
Outdated
Show resolved
Hide resolved
SohanTirpude
requested changes
Dec 12, 2023
src/genie/libs/parser/iosxe/tests/ShowPolicyMap/cli/equal/golden_output16_output.txt
Outdated
Show resolved
Hide resolved
|
Updates completed as requested, please review as nessesary. |
SohanTirpude
requested changes
Jan 10, 2024
src/genie/libs/parser/iosxe/tests/ShowPolicyMap/cli/equal/golden_output16_expected.py
Outdated
Show resolved
Hide resolved
SohanTirpude
requested review from
Taarini
and removed request for
sowmyadn010501
domachad
approved these changes
Feb 1, 2024
SohanTirpude
requested changes
Feb 2, 2024
|
Hello @mc4leaf, kindly pull the latest dev code. |
|
Master merged into dev branch and pushed. |
SohanTirpude
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added priority percent to show policy map for iosxe.
Description
#793