[Blitz] updated the docs for sequence keyword #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsheikal
requested review from
ThomasJRyan,
LukasMcClelland and
tahigash
and removed request for
ThomasJRyan
LukasMcClelland
approved these changes
Mar 17, 2022
miott
reviewed
Mar 17, 2022
docs/blitz/details/yang.rst
Outdated
| @@ -111,6 +111,7 @@ subscription, or, you may expect the test to fail (referred to as a negative tes | |||
| auto-validate: # [true | false] automatically validate config messages | |||
| negative-test: # [true | false] expecting device to return an error | |||
| pause: # pause N seconds between each test (default: 0, no pause) | |||
| sequence: # [true | false] to check the returns sequentially | |||
There was a problem hiding this comment.
Little vague. What about this instead: return values and return sequence verified
miott
reviewed
Mar 17, 2022
docs/blitz/details/yang.rst
Outdated
| @@ -111,6 +111,7 @@ subscription, or, you may expect the test to fail (referred to as a negative tes | |||
| auto-validate: # [true | false] automatically validate config messages | |||
| negative-test: # [true | false] expecting device to return an error | |||
| pause: # pause N seconds between each test (default: 0, no pause) | |||
| sequence: # [true | false] to check the return values and return sequence verified | |||
There was a problem hiding this comment.
You can drop the "to check the" from the sentence. What we really need is a detailed description of each option in format following this shorthand but I am not going to put that on you.
miott
approved these changes
Mar 18, 2022
tahigash
reviewed
Mar 22, 2022
tahigash
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.