Teamwhitelistsupportonclaims #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // continue auth with existing teammemberships for user | ||
| } | ||
|
|
||
| user.TeamMemberships = append(user.TeamMemberships, claimval) |
There was a problem hiding this comment.
append only if casting is success
handlers/auth.go
Outdated
| } | ||
| } | ||
| return false, fmt.Errorf("verifyUser: user.TeamMemberships %s not found in TeamWhiteList: %s for user %s", user.TeamMemberships, cfg.Cfg.TeamWhiteList, user.Username) |
There was a problem hiding this comment.
Is this needed when we have below return statement ?
kumarkowsikt
approved these changes
Mar 1, 2023
pkg/cfg/cfg.go
Outdated
| Domains []string `mapstructure:"domains"` | ||
| WhiteList []string `mapstructure:"whitelist"` | ||
| TeamWhiteList []string `mapstructure:"teamWhitelist"` | ||
| TeamWhiteListClaim string `mapstructure:"teamWhitelistclaim"` |
There was a problem hiding this comment.
Add description on how this attribute is used
pkg/providers/openid/openid.go
Outdated
| user.PrepareUserData() | ||
| return nil | ||
| } | ||
|
|
||
| // appendTeamMembershipsFromCustomClaim appends teammembership values in user If |
handlers/auth.go
Outdated
| if team == wl { | ||
| log.Debugf("verifyUser: Success! found user.TeamWhiteList in TeamWhiteList: %s for user %s", wl, user.Username) | ||
| return true, nil | ||
| log.Info("User not in userwhitelist, checking in teamWhiteList") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
teamwhitelisting based on claims present userinfo body