[minor change] New module for out-of-band contract creation (DCNE-219) #700
Conversation
akinross
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain,
sajagana,
samiib and
gmicol
github-actions
bot
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #700 +/- ##
===========================================
- Coverage 95.68% 21.25% -74.44%
===========================================
Files 270 4 -266
Lines 12404 1087 -11317
Branches 1869 246 -1623
===========================================
- Hits 11869 231 -11638
- Misses 404 836 +432
+ Partials 131 20 -111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2) Updated more assertations in test.py 3) merged the root and subclass1 into one single root class tests succeed finely PLAY RECAP ********************************************************************* azure_cloud : ok=8 changed=0 unreachable=0 failed=0 skipped=22 rescued=0 ignored=0 cn-dmz-apic-m1-02-v42 : ok=7 changed=0 unreachable=0 failed=0 skipped=23 rescued=0 ignored=0 cn-dmz-apic-m1-03-v52 : ok=26 changed=7 unreachable=0 failed=0 skipped=4 rescued=0 ignored=2 cn-dmz-apic-m1-04-v602h : ok=26 changed=7 unreachable=0 failed=0 skipped=4 rescued=0 ignored=2
2) added an example with Priority attribute set .
There was a problem hiding this comment.
sanity failures still there please fix
ERROR: plugins/modules/aci_oob_contract.py:0:0: parameter-type-not-in-doc: Argument 'name_alias' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/aci_oob_contract.py:0:0: undocumented-parameter: Argument 'name_alias' is listed in the argument_spec, but not documented in the module documentation
| - present_check_mode is changed | ||
| - present_check_mode.previous == [] | ||
| - present_check_mode.previous == present_check_mode.current | ||
| - present_check_mode.sent.vzOOBBrCP.attributes.name == 'anstest' |
There was a problem hiding this comment.
| - present_check_mode.sent.vzOOBBrCP.attributes.name == 'anstest' | |
| - present_check_mode.proposed.vzOOBBrCP.attributes.name == 'anstest' |
| - name: Create OOB Contract | ||
| cisco.aci.aci_oob_contract: &aci_oob_contract_present | ||
| <<: *aci_oob_contract_present_CM | ||
| state: "{{ fakevar | default(omit) }}" # >>>> DEFAULTS TO 'PRESENT' |
There was a problem hiding this comment.
why not just set present?
There was a problem hiding this comment.
for testing the default value when omitted
There was a problem hiding this comment.
ok then add that that is the intention of your test
| - absent_check_mode is changed | ||
| - absent_check_mode.previous != [] | ||
| - contract_absent is changed | ||
| - contract_absent.previous == absent_check_mode.previous |
There was a problem hiding this comment.
can you assert previous attributes?
added in module for oob_contract creation.
Updated test files for this as well.