Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch the mirror selection responsibility to serverless #41

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

EricRibeiro
Copy link
Contributor

@EricRibeiro EricRibeiro commented Dec 14, 2022

Motivation

Changes

  • Shifts the responsibility of mirror selection to serverless.

For whatever reason, the cloud provider we were getting the script from is throwing errors. So, instead of getting it from them, we will leave Serverles pick what is best based on the mirror parameter. They have some logic around it here:

if [[ $IS_IN_CHINA == "1" ]]
then
	# In China download from location in China (Github API download is slow and times out)
	BINARY_URL=https://sls-standalone-sv-1300963013.cos.na-siliconvalley.myqcloud.com/$TAG/serverless-$PLATFORM-$ARCH
else
	BINARY_URL=https://github.com/serverless/serverless/releases/download/$TAG/serverless-$PLATFORM-$ARCH
fi

@EricRibeiro EricRibeiro requested a review from a team as a code owner December 14, 2022 04:18
@KyleTryon KyleTryon merged commit cfd5d42 into master Dec 14, 2022
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:cfd5d423f61b2cec0ed875b2900fc6e62e1d09b7

1 similar comment
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:cfd5d423f61b2cec0ed875b2900fc6e62e1d09b7

@orb-publisher
Copy link

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=2.0.1

@EricRibeiro EricRibeiro deleted the fix/serverless_url branch December 14, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syntax error near unexpected token `newline'
5 participants