Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove provider check #32

Merged
merged 1 commit into from
Apr 25, 2022
Merged

feat!: remove provider check #32

merged 1 commit into from
Apr 25, 2022

Conversation

KyleTryon
Copy link
Contributor

Changes

This removed the provider check step.

  • The step aims to add CircleCI specific error messaging to help users configure the orb in theory but in practice may prevent the orb's usage.
  • Each potential cloud provider may have many methods of authentication which are valid
  • The AWS provider for instance at this time does not support role assumption
  • Most other cloud providers are not implemented in the command
  • The default error messages from the serverless cli should be clear enough to the issue

Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@KyleTryon KyleTryon merged commit aab4c35 into master Apr 25, 2022
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:aab4c35bdc4522df3a4477c6f709fbc1195c2cf1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants