Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select version parameter #29

Merged
merged 5 commits into from
Apr 22, 2022
Merged

feat: select version parameter #29

merged 5 commits into from
Apr 22, 2022

Conversation

KyleTryon
Copy link
Contributor

@KyleTryon KyleTryon commented Apr 22, 2022

This is a re-implement of #25.
Thank you to the original author. We wanted to refactor the orb and quickly release a major change with some upgrades without needing to ask contributors to make changes.

Feat

This PR adds a parameter to set the version of the serverless framework CLI to be installed. A new unit test was added to verify the install version.

Fix

This PR also includes a small fix for an issue encountered during testing. No Cloud Provider is needed to simply install the CLI, so in testing the provider was set to a blank string (which is a valid enum). This selection had not yet been accounted for. Added a simple echo statement to show that no option was selected rather than error.

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:ca182e676e7901b4234d19fa171d97a7fba4e47b

@KyleTryon
Copy link
Contributor Author

In testing, attempting to download version 2.72.3, the binary appeared to be downloaded but --version showed 2.72.2. Testing again with version3.15.0

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:026d3eba87b0ab624fc20610d49873f6bb8cf55b

Copy link
Contributor

@EricRibeiro EricRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KyleTryon KyleTryon merged commit 266132e into master Apr 22, 2022
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:266132eb8e02586e583671e188c0c4d0423e3c2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants