-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: select version parameter #29
Conversation
Your development orb has been published. It will expire in 30 days. |
In testing, attempting to download version |
Your development orb has been published. It will expire in 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your development orb has been published. It will expire in 30 days. |
This is a re-implement of #25.
Thank you to the original author. We wanted to refactor the orb and quickly release a major change with some upgrades without needing to ask contributors to make changes.
Feat
This PR adds a parameter to set the version of the serverless framework CLI to be installed. A new unit test was added to verify the install version.
Fix
This PR also includes a small fix for an issue encountered during testing. No Cloud Provider is needed to simply install the CLI, so in testing the
provider
was set to a blank string (which is a valid enum). This selection had not yet been accounted for. Added a simple echo statement to show that no option was selected rather than error.