Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: orb tools 11 migration #27

Merged
merged 11 commits into from
Apr 21, 2022
Merged

refactor!: orb tools 11 migration #27

merged 11 commits into from
Apr 21, 2022

Conversation

KyleTryon
Copy link
Contributor

@KyleTryon KyleTryon commented Apr 19, 2022

Orb tools 11 migration with major changes incoming.

This will not be released immediately more PRs will follow this one.

Removed:

echo y | serverless --org "$SERVERLESS_ORB_ORG_NAME" --app "$SERVERLESS_ORB_APP_NAME"

Why?

This line when testing this refactor resulted in this error. In searching for this CLI command in the serverless framework docs, I was not able to find any reference to this --org --app style command, and I believe it may potentially be deprecated at this time. Running serverless -h will show no such options are documented.

Error:
Attempted to run an interactive setup in non TTY environment.
If that's intended, run with the SLS_INTERACTIVE_SETUP_ENABLE=1 environment variable

The test here will show that these are not needed for deployment.
image

It appears their original purpose may have aided in creating a new project if one had not existed, and this should be rare and likely not encouraged.

In a future PR I will remove these parameters before we release a major update.

@CircleCI-Public CircleCI-Public deleted a comment from orb-publisher Apr 20, 2022
@KyleTryon KyleTryon changed the title refactor: orb tools 11 migration refactor!: orb tools 11 migration Apr 21, 2022
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:6b75b19082d51ae23c6ed4894cf9fa52e810e437

@CircleCI-Public CircleCI-Public deleted a comment from orb-publisher Apr 21, 2022
README.md Show resolved Hide resolved
orb.yml Outdated
@@ -0,0 +1,266 @@
version: 2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file probably was pushed unintentionally. It's not in the current version of the .gitignore. Can you add it there?

src/scripts/provider-check.sh Outdated Show resolved Hide resolved
src/scripts/provider-check.sh Outdated Show resolved Hide resolved
src/scripts/provider-check.sh Outdated Show resolved Hide resolved
src/scripts/provider-check.sh Outdated Show resolved Hide resolved
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:198694449b36455f7a1893fe3c265118ae767c8d

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:96c123cc0151d229f66425e9fe149c9078bc5f59

@KyleTryon KyleTryon merged commit ebb4a77 into master Apr 21, 2022
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/serverless-framework?version=dev:ebb4a777860b1edcff9672f6a5b6583a666cc430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants