Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes path expansion #12

Closed
wants to merge 1 commit into from

Conversation

nyoungstudios
Copy link

The environment variables in this line are being expanded before appended to the $BASH_ENV file. Single quotes ensures that it won't be expanded when it is appended to the $BASH_ENV file.

This is the same problem as outlined here: CircleCI-Public/gcp-cli-orb#22

A good way to check this is to ssh into the CircleCI job after doing the serverless/setup command. And try to run python. In the current situation, python will fail to run, but after this fix, python will work correctly.

@nyoungstudios
Copy link
Author

Moved to the Alpha branch: #13

@alexeyshockov
Copy link

Hey, any news here? I'm experiencing the same problem...

@nyoungstudios
Copy link
Author

@alexeyshockov the easiest way to work around this right now is to not use the orb, but instead run the curl, echo, and source commands in this pr directly in a run step like this: https://github.com/nyoungstudios/py-lambda-circleci/blob/main/.circleci/config.yml

@KyleTryon can we get this merged?

@KyleTryon KyleTryon self-assigned this Apr 14, 2022
@KyleTryon KyleTryon mentioned this pull request Apr 22, 2022
@KyleTryon
Copy link
Contributor

Hey all, very sorry for the long delay. I am doing a big maintenance sweep right now, and to keep everything moving quickly now I have re-implemented this change in a new PR to avoid these conflicts and integrate better with some new changes. Keep an eye out for the next release coming soon (hopefully today!). There will be a new tag/release with more info.

This change is currently now in #30

@KyleTryon KyleTryon closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants