migrate-3-to-4: use mongo data volume for backup #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atulsingh0
approved these changes
May 8, 2023
atulsingh0
previously requested changes
May 9, 2023
Co-authored-by: Atul S <[email protected]>
ryanwohara
dismissed
atulsingh0’s stale review
Atul is OOO and we would like this to get in before 4.2
ryanwohara
approved these changes
Jul 7, 2023
|
Thanks Pat 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ Issue
With our installation, our mongo db was 17GB on disk, and 52GB in the export format. Our data volume was expanded to 100GB previously, but there was no way the export would have fit into /tmp (only 50GB with 17GB in use).
✅ Fix
This fix just uses the data volume which (in our case) already had the space available, but there is probably a better way to create a large temporary volume for the backup process.
❓ Tests
This code got us to 4.x. 😃