server-2047 | defaulted release name #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbialy
approved these changes
Aug 19, 2022
lloydChris
reviewed
Aug 19, 2022
| rm_kots_annot_label_resources | ||
| execute_flyway_migration |
There was a problem hiding this comment.
Why is this changing order?
There was a problem hiding this comment.
By running execute_flyway_migration at last, in case of execute_flyway_migration fail (which terminates the script as well), allow us to only re-run the execute_flyway_migration
Currently, we have to run 2 function (execute_flyway_migration and rm_kots_annot_label_resources)
lloydChris
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ Issue
SERVER-2047
✅ Fix
circleci-server❓ Tests