Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERVER-2047 | added job deletion step #23

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

atulsingh0
Copy link
Contributor

⚙️ Issue
SERVER-2047

  • Script will abort if job circle-migrator is not finished in 300 secs

Fix

  • Added instructions to follow if job circle-migrator is not finished in 300 secs
  • Change error_exit to echo
  • Added check_postreq function to check k8s namespace and helm release

Tests

  • Tested Updating Existing Instance
  • Installed on new instance

@atulsingh0 atulsingh0 requested review from jbialy and a team August 17, 2022 16:45
@atulsingh0 atulsingh0 force-pushed the server-2047-flyway-migration-job branch from 0780af3 to 619833d Compare August 17, 2022 16:49
Copy link
Contributor

@circlery circlery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good work!

@atulsingh0 atulsingh0 requested review from soulchips and a team August 17, 2022 17:27
@atulsingh0 atulsingh0 force-pushed the server-2047-flyway-migration-job branch from 71e2882 to 0f0b381 Compare August 17, 2022 19:54
@atulsingh0 atulsingh0 merged commit 9767dad into main Aug 17, 2022
@atulsingh0 atulsingh0 deleted the server-2047-flyway-migration-job branch August 17, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants