Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(install-chrome.sh): Chrome install not working on ARM executors #73

Merged
merged 2 commits into from
Jul 18, 2023
Merged

fix(install-chrome.sh): Chrome install not working on ARM executors #73

merged 2 commits into from
Jul 18, 2023

Conversation

itsyuvalcohen
Copy link
Contributor

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

Chrome installations on ARM executors fails due to a bad architecture check causing it to use amd64 instead of arm64

Description

Fixed ENV_IS_ARM variable

@itsyuvalcohen itsyuvalcohen requested a review from a team as a code owner July 17, 2023 10:19
@ryanbourdais ryanbourdais self-assigned this Jul 17, 2023
ryanbourdais
ryanbourdais suggested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@ryanbourdais ryanbourdais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I left a note in your changes

src/scripts/install-chrome.sh Outdated
@@ -106,9 +106,9 @@ else
# download chrome
echo "Preparing Chrome installation for Debian-based systems"
if [[ "$ORB_PARAM_CHROME_VERSION" == "latest" ]]; then
ENV_IS_ARM=$(! dpkg --print-architecture | grep -q arm; echo $?)
ENV_IS_ARM=$(dpkg --print-architecture | grep arm64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried test running these changes and now most of the tests are failing, I think that this line should go back to how it was originally but replacing line 111 with if [ "$ENV_IS_ARM" == "1" ]; then would fix this issue

@itsyuvalcohen
Copy link
Contributor Author

Thanks for the contribution, I left a note in your changes

I figured out google doesn't even publish google-chrome-stable for arm64, I think we should exit with an error saying it isn't supported

@ryanbourdais
Copy link
Contributor

Thanks for the contribution, I left a note in your changes

I figured out google doesn't even publish google-chrome-stable for arm64, I think we should exit with an error saying it isn't supported

If you would like to make that change on this PR I can get that merged in, otherwise I can just close this PR out.

ryanbourdais
ryanbourdais approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@ryanbourdais ryanbourdais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ryanbourdais ryanbourdais merged commit e3202fe into CircleCI-Public:main Jul 18, 2023
@m3thom
Copy link

m3thom commented Jul 11, 2024

If I understand correctly, we should be able to install Chrome on ARM when this issue is resolved, no?
GoogleChromeLabs/chrome-for-testing#1

m3thom added a commit to m3thom/rails-7-system-test-circle-ci that referenced this pull request Jul 11, 2024
@m3thom
ci: Change back to use amd architecture
f9b81bf 
Chrome arm issue: GoogleChromeLabs/chrome-for-testing#1
browser-tools arm issue: CircleCI-Public/browser-tools-orb#73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanbourdais ryanbourdais ryanbourdais approved these changes

Assignees

@ryanbourdais ryanbourdais

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsyuvalcohen @ryanbourdais @m3thom