Skip to content

chore: added base_url parameter to CohereReranking #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

chore: added base_url parameter to CohereReranking #743

merged 1 commit into from
Jun 5, 2025

Conversation

mginfn
Copy link
Contributor

@mginfn mginfn commented Apr 30, 2025

Description

Added base_url parameter to CohereReranking to enable Cohere-compatible rerank API, e.g. vLLM rerank API and KServe rerank support.

Type of change

  • New features (non-breaking change).
  • Bug fix (non-breaking change).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).

Checklist

  • I have performed a self-review of my code.
  • I have added thorough tests if it is a core feature.
  • There is a reference to the original bug report and related work.
  • I have commented on my code, particularly in hard-to-understand areas.
  • The feature is well documented.

@mginfn
Copy link
Contributor Author

mginfn commented May 5, 2025

Hi, this is a very small PR, anyone willing to review? Thanks

@phv2312 phv2312 merged commit ffe766f into Cinnamon:main Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phv2312 phv2312 phv2312 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mginfn @phv2312