Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit size of binary image to 1 million bytes. #96

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

redwarp
Copy link
Collaborator

@redwarp redwarp commented Aug 16, 2019

It prevents the SQLiteBlobTooBigException that would happen when downloading big images.

Fixes #94

@redwarp redwarp requested a review from cortinico August 16, 2019 08:45
@redwarp redwarp force-pushed the dont_store_images_if_too_big branch from c7a0310 to d20b991 Compare August 16, 2019 10:52
@redwarp
Copy link
Collaborator Author

redwarp commented Aug 16, 2019

Extracted 1000_000L to a constant.

@redwarp redwarp force-pushed the dont_store_images_if_too_big branch from d20b991 to c2239a1 Compare August 16, 2019 12:51
…BlobTooBigException that would happen when downloading big images.

Fixes ChuckerTeam#94
@redwarp redwarp force-pushed the dont_store_images_if_too_big branch from c2239a1 to 9d70b28 Compare August 16, 2019 12:54
@cortinico cortinico merged commit 71a5036 into ChuckerTeam:develop Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image that are too big will make chucker crash
2 participants