Add color to request and response body when content-type is json #930

Amirhy · 2022-11-28T11:42:18Z

📷 Screenshots

📄 Context

I have been using chucker for a long time. But the gray texts in the body of the requests and responses bothered me and my teammates's eyes and also made it difficult for us to read the texts properly.
So I decided to color the text of body of requests and responses.
Although I've only done it for application/json content-type and I'll support the rest of them soon.
I also fixed a bug that if there is no HeaderItem type inside the adapter items and you search for a text in the body of requests and responses, the text does not highlight properly.

📝 Changes

Implement colorful text for body of request and response when content-type is application/json

🚫 Breaking

🛠️ How to test

I just write some tests for json formatting in SpanUtilTest class that you can run them and also you can do functional testing.

⏱️ Next steps

Implement this feature for other content-types , for example application/xml

…_colorful_body

at TransactionPayloadAdapter.kt

cortinico · 2022-12-02T10:43:36Z

Thanks for sending this @Amirhy. I won't be able to review this till sometime next week as I'm a bit busy at the moment 👍

Amirhy · 2022-12-11T08:37:39Z

Hi @cortinico. Hope you 're doing well.
Did you have free time to review my PR?

cortinico · 2022-12-13T15:04:10Z

Did you have free time to review my PR?

Sorry I was quite busy this week. I'll have to look into this over the next weekend.
In the meanwhile @ArjanSM do you want to do a pass here?

ArjanSM · 2022-12-14T03:23:45Z

Did you have free time to review my PR?

Sorry I was quite busy this week. I'll have to look into this over the next weekend. In the meanwhile @ArjanSM do you want to do a pass here?

@cortinico I've been a little occupied today. I'll take a look at it tomorrow.

ArjanSM

Thanks for the PR @Amirhy 🏅
I've made a few suggestions.
Also, I personally feel that it would be nice if you could create different PRs (one for text coloring feature and the other for the Text highlighting bug) or the reference to the feature issue and the bug in the PR description.

library/src/main/kotlin/com/chuckerteam/chucker/internal/support/SpanTextUtil.kt

Amirhy · 2022-12-24T00:52:55Z

Thanks for the PR @Amirhy 🏅 I've made a few suggestions. Also, I personally feel that it would be nice if you could create different PRs (one for text coloring feature and the other for the Text highlighting bug) or the reference to the feature issue and the bug in the PR description.

Thanks for your time @ArjanSM. I will fix them as soon as possible.

…_colorful_body

…lorful_body

Amirhy · 2022-12-25T07:00:32Z

Thanks for the PR @Amirhy 🏅 I've made a few suggestions. Also, I personally feel that it would be nice if you could create different PRs (one for text coloring feature and the other for the Text highlighting bug) or the reference to the feature issue and the bug in the PR description.

Ok I removed my changes that fix the mentioned bug, and I will create another PR for them.

Amirhy · 2023-01-04T11:44:21Z

@cortinico @ArjanSM kindly reminder

ArjanSM

sorry for the delay. Just a few to nits to begin with. I'll give it a more thorough pass later in the week.

library/src/androidTest/kotlin/com/chuckerteam/chucker/SpanUtilTest.kt

...src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionPayloadAdapter.kt

...rc/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionPayloadFragment.kt

Amirhy · 2023-02-07T07:16:45Z

sorry for the delay. Just a few to nits to begin with. I'll give it a more thorough pass later in the week.

Hi @ArjanSM,

Hope you are doing well.

I resolved all threads you created.Please let me know if you have any other comment.

ArjanSM

Getting there!
Just a bunch of few nits.

library/src/main/kotlin/com/chuckerteam/chucker/internal/support/SpanTextUtil.kt

…_colorful_body

Amirhy · 2023-02-22T06:43:00Z

Hi Dear @ArjanSM

Do you have any new nits about my changes? ;-)

I want you check this comment and let me know what is your opinion?

cortinico

Code looks good to me 👍 @ArjanSM already did a great review!
Only left a minor nits.

library/src/main/kotlin/com/chuckerteam/chucker/internal/support/SpanTextUtil.kt

cortinico · 2023-02-25T17:38:22Z

...rc/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionPayloadFragment.kt

+        if (result.isEmpty())
+            result.add(subSequence(0, length))


That's because when the char sequence doesn't have any lines so I should add all of its content to the result.

…_colorful_body

ArjanSM · 2023-03-03T15:15:45Z

Hi Dear @ArjanSM

Do you have any new nits about my changes? ;-)

I want you check this comment and let me know what is your opinion?

Aah! my bad! 👍

cortinico

This is awesome @Amirhy Thanks for taking the time to add this feature!

misael-jonathan · 2023-04-12T10:16:16Z

hi @Amirhy , I think there's performance issue when we used this implementation in large json data. I just updated my chucker with this colored request/response, in some cases it took 2-3 secs to load my response, and if its super big it'll just stuck on loading state. Can u verify this issue on your side?

Amirhy · 2023-04-16T13:17:54Z

Hi @misael-jonathan ,
Thanks for sharing your experience.
If it is possible please send me your json to my email ([email protected])
I will investigate on it and inform you as soon as possible.

misael-jonathan · 2023-04-17T05:02:59Z

Hi, I just sent the json to your email. Actually it is the same json you can find in LargeJson.kt in the sample app.
So, I think you can start from there.

Thanks @Amirhy

AmirHosein Hoseini added 8 commits November 23, 2022 16:41

implement Spannable Body For Response

bc92e2c

add some test case

079b152

fix color issue

cab7bfc

rename test function

30ee6ed

add spanned request body

7cf8087

Merge branch 'develop' of https://github.com/Amirhy/chucker into feat…

3df30f5

…_colorful_body

handle adding and removing highlighting spans when search a word

2d16c8d

fix a bug when highlighting searched text and there is no header item

9d56bd8

at TransactionPayloadAdapter.kt

Amirhy changed the title ~~Feat colorful body~~ Add color to request and response body when content-type is json Nov 28, 2022

AmirHosein Hoseini added 3 commits November 29, 2022 11:29

try to resolve detekt errors

689f7f0

resolve detekt errors

86e0221

resolve detekt errors

a1b459e

ArjanSM reviewed Dec 17, 2022

View reviewed changes

Amirhy and others added 6 commits December 24, 2022 18:53

Merge branch 'ChuckerTeam:develop' into feat_colorful_body

9cbe545

Merge branch 'develop' of https://github.com/Amirhy/chucker into feat…

2e2bf8c

…_colorful_body

refactor SpanTextUtil.kt

ec23c91

remove bug fix codes from this branch

1943db4

fix indent issue

f39612f

Merge remote-tracking branch 'origin/feat_colorful_body' into feat_co…

7e96474

…lorful_body

ArjanSM reviewed Jan 24, 2023

View reviewed changes

fix merge request comments

3b77798

Amirhy closed this Feb 7, 2023

Amirhy reopened this Feb 7, 2023

ArjanSM reviewed Feb 13, 2023

View reviewed changes

AmirHosein Hoseini added 3 commits February 15, 2023 10:50

Merge branch 'develop' of https://github.com/Amirhy/chucker into feat…

5596e2f

…_colorful_body

some improvement

aefcb9f

change test method's name

bee1044

cortinico reviewed Feb 25, 2023

View reviewed changes

AmirHosein Hoseini added 2 commits February 26, 2023 09:21

Merge branch 'develop' of https://github.com/Amirhy/chucker into feat…

1982e83

…_colorful_body

handle dark mode in json colors

edb81b1

Amirhy requested a review from a team as a code owner February 28, 2023 08:17

Merge branch 'develop' of https://github.com/Amirhy/chucker into feat…

c747060

…_colorful_body

ArjanSM approved these changes Mar 3, 2023

View reviewed changes

cortinico approved these changes Mar 4, 2023

View reviewed changes

cortinico merged commit 3ae4d08 into ChuckerTeam:develop Mar 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add color to request and response body when content-type is json #930

Add color to request and response body when content-type is json #930

Amirhy commented Nov 28, 2022 •

edited

Loading

cortinico commented Dec 2, 2022

Amirhy commented Dec 11, 2022

cortinico commented Dec 13, 2022

ArjanSM commented Dec 14, 2022

ArjanSM left a comment

Amirhy commented Dec 24, 2022

Amirhy commented Dec 25, 2022

Amirhy commented Jan 4, 2023 •

edited

Loading

ArjanSM left a comment

Amirhy commented Feb 7, 2023

ArjanSM left a comment

Amirhy commented Feb 22, 2023

cortinico left a comment

cortinico Feb 25, 2023

Amirhy Feb 28, 2023

ArjanSM commented Mar 3, 2023

cortinico left a comment

misael-jonathan commented Apr 12, 2023

Amirhy commented Apr 16, 2023

misael-jonathan commented Apr 17, 2023

Add color to request and response body when content-type is json #930

Add color to request and response body when content-type is json #930

Conversation

Amirhy commented Nov 28, 2022 • edited Loading

📷 Screenshots

📄 Context

📝 Changes

🚫 Breaking

🛠️ How to test

⏱️ Next steps

cortinico commented Dec 2, 2022

Amirhy commented Dec 11, 2022

cortinico commented Dec 13, 2022

ArjanSM commented Dec 14, 2022

ArjanSM left a comment

Choose a reason for hiding this comment

Amirhy commented Dec 24, 2022

Amirhy commented Dec 25, 2022

Amirhy commented Jan 4, 2023 • edited Loading

ArjanSM left a comment

Choose a reason for hiding this comment

Amirhy commented Feb 7, 2023

ArjanSM left a comment

Choose a reason for hiding this comment

Amirhy commented Feb 22, 2023

cortinico left a comment

Choose a reason for hiding this comment

cortinico Feb 25, 2023

Choose a reason for hiding this comment

Amirhy Feb 28, 2023

Choose a reason for hiding this comment

ArjanSM commented Mar 3, 2023

cortinico left a comment

Choose a reason for hiding this comment

misael-jonathan commented Apr 12, 2023

Amirhy commented Apr 16, 2023

misael-jonathan commented Apr 17, 2023

Amirhy commented Nov 28, 2022 •

edited

Loading

Amirhy commented Jan 4, 2023 •

edited

Loading