Correctly set FLAG_IMMUTABLE for error screen PendingIntent
#653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, we forgot to add flag for this intent because in develop we already removed errors tab and I missed it during cherrypicking. |
vbuberen
approved these changes
Jul 16, 2021
MiSikora
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Context
Originally reported here #634 (comment)
When we backported this PR #593, the
PendingIntentfor the error screen slipped through. Therefore users📝 Changes
Just adding the
FLAG_IMMUTABLEto the onlyPendingIntentthat was missing it.📎 Related PR
#593 and #637
🛠️ How to test
I haven't tested this, it's a best guess fix.
⏱️ Next steps
We should potentially release
3.5.1with this fix included. Wdyt @vbuberen @MiSikora