Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a shortcut when creating ChuckerInterceptor #588

Merged
merged 13 commits into from
Mar 26, 2021
Merged

Add a shortcut when creating ChuckerInterceptor #588

merged 13 commits into from
Mar 26, 2021

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Mar 25, 2021 •
edited
Loading

  • Add a shortcut when creating ChuckerInterceptor for launch MainActivity like LeakCanary

screenshot

@Goooler
Copy link
Contributor Author

Goooler commented Mar 25, 2021

It seems api test failed, how can I solve it.

MiSikora
MiSikora reviewed Mar 25, 2021
View reviewed changes
Copy link
Contributor

@MiSikora MiSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems api test failed, how can I solve it.

By making function you added internal or by executing apiDump Gradle task.

library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated Show resolved Hide resolved
library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated Show resolved Hide resolved
library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated Show resolved Hide resolved
library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated Show resolved Hide resolved
library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated Show resolved Hide resolved
library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated Show resolved Hide resolved
library/src/main/java/com/chuckerteam/chucker/api/ChuckerInterceptor.kt Outdated Show resolved Hide resolved
@vbuberen
Copy link
Collaborator

I am curios if we need this feature before proceeding with the reviw.

@MiSikora
Copy link
Contributor

Personally I like it. I won't fight for it, but I see it as a useful thing.

@Goooler Goooler requested a review from MiSikora March 26, 2021 02:41
@Goooler Goooler requested a review from vbuberen March 26, 2021 02:51
@Goooler Goooler requested a review from MiSikora March 26, 2021 06:58
MiSikora
MiSikora approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@MiSikora MiSikora left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment, but other than that, LGTM. 🚀

Thank you for this contribution! I'll wait with merging for a second review/opinion.

You'll also need to execute apiDump Gradle task because a public function was added to the builder.

library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated Show resolved Hide resolved
@Goooler Goooler requested a review from MiSikora March 26, 2021 07:09
@cortinico
Copy link
Member

I think this is a nice addition 👍
Should we add a note to the README?

@vbuberen
Copy link
Collaborator

Should we add a note to the README?

I will take care of it in a follow-up PR for this feature.

@vbuberen vbuberen merged commit 664730a into ChuckerTeam:develop Mar 26, 2021
@vbuberen vbuberen mentioned this pull request Mar 26, 2021
Merged
@vbuberen vbuberen added the enhancement New feature or improvement to the library label Mar 26, 2021
@vbuberen vbuberen added this to the 4.0.0 milestone Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiSikora MiSikora MiSikora approved these changes

@vbuberen vbuberen vbuberen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or improvement to the library
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Goooler @vbuberen @MiSikora @cortinico