Refactor config and disable autodetect if the config is provided #85
+57
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So something I've run into with my personal setup is that if you have an HMD via OpenHMD, but no controllers, OpenHMD's "null" drivers tend to occupy the left/right controller slots.
However, for some circumstances (i.e. confirming function of the driver), using the null drivers is wanted, so ignoring them is not advisible.
Owing to this, I've modified how the config is handled. Autodetection is now disabled if an explicit config file is provided, and there are now proper default values rather than uninitialized memory.