[FEAT] TweakToggles logik overhaul #3014
Merged
+341
−633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove Invoke-WPFToggle.ps1 - generalize Get-WinUtilToggleStatus - add bingsearch reg key for testing - use Invoke-WinUtilTweaks for actions - replace Add-Click with checked & unchecked to make undo work
- add all reg keys to tweaks.json into existing toggle entry - remove unneeded scripts
…prepended to the return value so the result becomes ("hku", $false). In powershell pretty much every variable that exists is interpreted as $true so the toggle for numlock got incorrectly checked
- fix HKU issue globally - remove some console logs, change some others to write-debug
- change Invoke-WinUtilExplorerRefresh to handle refresh and restart - add restart logic to window snapping Flyout & Suggestions - rename Invoke-WinUtilExplorerRefresh to Invoke-WinUtilExplorerUpdate
add explorer restart logic for hidden files + Fileextension toggles
- fix issue defining WindowArrangementActive as dword instead of string
- switch bing search enabled/disabled values
og-mrk
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Although there's room for improvement (especially in Error Handling), the current changes work as intended. Well done @MyDrift-user 😄
- add error handling for Get-WinUtilToggleStatus
ChrisTitusTech
approved these changes
Dec 6, 2024
|
Great job with this @MyDrift-user |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Every time i worked / wanted to work with them i got annoyed. You define the path and values 3 times i think. The validation, error handling and so one are done seperately for each toggle.
Testing
TODO:
Checklist