Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Window Statechange on doubleclick works everywhere #2768

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

Marterich
Copy link
Contributor

@Marterich Marterich commented Sep 19, 2024

Type of Change

  • Bug fix

Description

This Binds the DoubleClick action only to StackPanel and Grid.
Before, even when you double-clicked on a button or a text field, the window would toggle between fullscreen and windowed.

Testing

Tested locally on Win11 23H2

Impact

The Window wont behave irrationally anymore when double clicking on stuff

Issue related to PR

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.

Copy link
Contributor

@MyDrift-user MyDrift-user left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never got this to work myself, but this works great :)

@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 20, 2024
@ChrisTitusTech ChrisTitusTech merged commit 9136ed9 into ChrisTitusTech:main Sep 20, 2024
1 check passed
@Marterich Marterich deleted the fix-doubleclick branch October 3, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double clicking the search bar to select all fullscreens winutil
3 participants