-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option to Block Razer automatic installs #2715
Conversation
commit c674d5e Author: Saksham Singh <[email protected]> Date: Wed Sep 11 19:34:44 2024 +0530 desc update commit 3d8bf2b Author: Saksham Singh <[email protected]> Date: Wed Sep 11 19:30:23 2024 +0530 Added Razer Block Added the razer block by chris titus under the Fixes Section
Hello @xicor22, Thank you for your PR but this would be a tweak and not a feature. Please could this be moved to tweaks.json under the Advanced Tweaks Section. |
even though i select another tweak to get around that bug, my razer block tweak is still not getting applied |
I looked at this for quite a while and cant seem to find any issues but the code in invoke script is not running. Am I missing something here? The previous "select a tweaks" error was caused because I didn't put "Tweak" in "WPFRazerBlock". |
Hey @xicor22, thanks for the PR, you moved the reg changes into the invoke- & undo script again, could you please add them sepeately like you did before? Also the function wrapping and calling kind of seems unneccessary due to it only beeing called there. Otherwise I think it looks good :) |
I just made the requested changes and tested them. Everything's working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, looks fine to me now 👍
You forgot to remove the comma in feature.json |
* Squashed commit of the following: commit c674d5e Author: Saksham Singh <[email protected]> Date: Wed Sep 11 19:34:44 2024 +0530 desc update commit 3d8bf2b Author: Saksham Singh <[email protected]> Date: Wed Sep 11 19:30:23 2024 +0530 Added Razer Block Added the razer block by chris titus under the Fixes Section * Moved razer-block from features to tweaks * Updated tweaks.json * Added option to enable ssh server under config tab * Revert "Added option to enable ssh server under config tab" This reverts commit ade4142. * Added Option to enable ssh server under config tab * updated docs * Removed #2715 from this PR * update variable name * Fixed authorized_keys file creation issue auth key file was not being created due to incomplete file path from the $env:HOMEPATH and also corrected the ssh directory to .ssh
Type of Change
Description
Added the option to block automatic installation of razer software using the code from the chris titus original Block-Razer repo.
Testing
Tested for the following cases:
Issue related to PR
Additional Information
Checklist