Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Image handling #2665

Merged
merged 12 commits into from
Sep 10, 2024
Merged

Better Image handling #2665

merged 12 commits into from
Sep 10, 2024

Conversation

MyDrift-user
Copy link
Contributor

@MyDrift-user MyDrift-user commented Sep 1, 2024 •
edited
Loading

Pull Request

DEPENDENCY: ChrisTitusTech/website#216

Better Image handling

Type of Change

  • Refactoring
  • UI/UX improvement

Description

  • instead of making a lot of webrequests to christitus.com for the images which may slow down startup of winutil with bad network connection, we now use our own integraded images.
  • The only webrequest for images is now only done for the .ico image needed for the shortcut. That image will only be downloaded if shortcut is created.

old:
image

new:
image

shortcut:
image

old:
image

new:
image
new if shortcut ico is available:
image

Testing

  • tested locally & worked
  • tested shortcut ico save logic using own repo link, worked

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@MyDrift-user
enhance asset mgmt
274daae 
- invoke ico directly
- invoke ico only at shortcut creation
- remove "ConvertTo-Icon" Function file

- removed image from xaml
- added stackpanel to xaml
- added functions to create viewbox with image
- added logic to add image via code to xaml & customdialog
- changed title color for customdialog

- remove webinvokes for assets from main.ps1

TODO: convert images into bitmap base64 string & add them directly into invoke-WinUtiltaskbaritem.ps1
@MyDrift-user
improve viewboxfunction
2e757c5 
- add logo + checkmark + warning
- add params
- render on param "render"
- custom dialog logo function call fix
- main logo function call fix
- update winutiltaskbaritem to use new images
@MyDrift-user
fix sizing
b41203d 
- warning & checkmark sizing fix
- remove unneded comments
@MyDrift-user
fixes
26fe1f2 
- remove unneeded redundancy of "$canvas = New-Object Windows.Controls.Canvas"
- adjust empty lines
- use LimeGreen instead of Green
@MyDrift-user
fix layouting
7cb0256
@MyDrift-user MyDrift-user mentioned this pull request Sep 1, 2024
Merged
@MyDrift-user MyDrift-user marked this pull request as ready for review September 3, 2024 19:18
@MyDrift-user MyDrift-user marked this pull request as draft September 3, 2024 19:31
@MyDrift-user
fixes
4b741ce 
- use correct ctt blue color #0567ff
- remove unneeded comments
- rename Logoview to assets
@MyDrift-user
performance improvement
5885c06 
instead of rendering the image another time on each item switch, it caches it at the start and uses the render afterwards
@MyDrift-user MyDrift-user marked this pull request as ready for review September 3, 2024 19:54
@ChrisTitusTech ChrisTitusTech merged commit 5059b93 into ChrisTitusTech:main Sep 10, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
ChrisTitusTech added a commit that referenced this pull request Sep 11, 2024
@ChrisTitusTech
Revert "Better Image handling (#2665)"
1da39b1 
This reverts commit 5059b93.
@ChrisTitusTech ChrisTitusTech mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTitusTech ChrisTitusTech Awaiting requested review from ChrisTitusTech ChrisTitusTech is a code owner

Assignees
No one assigned
Labels
skip-changelog Skip Change Logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MyDrift-user @ChrisTitusTech