Fix (?) button opening the link twice #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Real-MullaC
approved these changes
Sep 2, 2024
MyDrift-user
approved these changes
Sep 3, 2024
ChrisTitusTech
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Fix (?) button opening the link twice
Type of Change
Description
(?) button causes the tooltip link to be opened twice. This is caused by having 2 seperate functions opening the link. One is in functions\public\Invoke-WPFUIElements.ps1 on lines 307-312 and the other one is in functions\private\Show-CustomDialog.ps1 on line 227.
I have deleted the one on WPFUIElements to prevent double tab opening.
Testing
I have compiled the script on my own computer after the change and It seems to be working well and the tooltip now opens 1 tab only.
Issue related to PR
Checklist