Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shortcut creation #2488

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

MyDrift-user
Copy link
Contributor

@MyDrift-user MyDrift-user commented Jul 30, 2024

Pull Request

Fix Shortcut creation

Type of Change

  • Bug fix

Description

  • using vars that actually exist instead of imaginary ones.
  • remove empty row at the start of the file

Testing

tested, did not work before, works now

Issue related to PR

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

- using vars that actually exist instead of imaginary ones.
- remove empty row at the start of the file
@michaeldun123
Copy link

I've actually just made an issue regarding this :D #2510

Copy link

@Progressandfortuna Progressandfortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran scrip locally.
works.

Copy link
Contributor

@og-mrk og-mrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because GitHub doesn't allow adding review comments on lines that haven't changed by PR, I'll mention it here..

@MyDrift-user If you can/have the time, can you remove the empty line shown below?

Screenshot (Click to expand)

I know it's something to nit-pick, and it isn't even a concern of this PR.. but if you're modifying same file, might as well point out other "issues" it might have (which again, not really a big deal).

Overall, nice fix to Shortcut Creation 👍

EDIT: @MyDrift-user Can you add Issue #2520 to the Issue related to PR section?

@MyDrift-user
Copy link
Contributor Author

Hey @og-mrk
Thanks for the advice, the link does not direct me to an empty line, if you mean the one before the function in the file I have already removed it, if not I do not know which line you mean..

@og-mrk
Copy link
Contributor

og-mrk commented Aug 5, 2024

Hey @og-mrk Thanks for the advice, the link does not direct me to an empty line, if you mean the one before the function in the file I have already removed it, if not I do not know which line you mean..

@MyDrift-user Updated the review comment, added a screenshot with the empty line in question highlighted in a gray-ish yellow highlighting.

remove unneccessary empty row
Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ChrisTitusTech ChrisTitusTech merged commit 97f67fa into ChrisTitusTech:main Aug 6, 2024
@MagmaBro123
Copy link

Seems this still ocurrs.

@MyDrift-user
Copy link
Contributor Author

Seems this still ocurrs.

@MagmaBro123 this will be fixed for the following release

@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
7 participants