-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix shortcut creation #2488
fix shortcut creation #2488
Conversation
- using vars that actually exist instead of imaginary ones. - remove empty row at the start of the file
I've actually just made an issue regarding this :D #2510 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran scrip locally.
works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because GitHub doesn't allow adding review comments on lines that haven't changed by PR, I'll mention it here..
@MyDrift-user If you can/have the time, can you remove the empty line shown below?
I know it's something to nit-pick, and it isn't even a concern of this PR.. but if you're modifying same file, might as well point out other "issues" it might have (which again, not really a big deal).
Overall, nice fix to Shortcut Creation 👍
EDIT: @MyDrift-user Can you add Issue #2520 to the Issue related to PR
section?
Hey @og-mrk |
@MyDrift-user Updated the review comment, added a screenshot with the empty line in question highlighted in a gray-ish yellow highlighting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Seems this still ocurrs. |
@MagmaBro123 this will be fixed for the following release |
Pull Request
Fix Shortcut creation
Type of Change
Description
Testing
tested, did not work before, works now
Issue related to PR
Checklist