Simple Fix for Taskbar - Change Progress Variable Name from 'x' to 'i' inside 'Install-WinUtilProgramWinget' Private Function #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' inside 'Install-WinUtilProgramWinget' Private Function
|
this is better but still does not fix the issue for me. The progress value still is always 0 and does not go on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Because of the recent Flood of PRs to WinUtil, some overlapping happened as some PRs were changing same files as other (not in Merge Conflicts, but in Code Logic), therefore PR #2309 had its variable naming out-of-sync when PR #2396 was merged.
This PR fixes this to bring back what's @MyDrift-user originally intended of showing a Progress bar in Task Item for WinUtil.
Testing
Tested it by selecting multiple items to install, and it works as expected.
Impact
Brings back progress bar in task item when installing/uninstalling using WinGet Package Manager.
Checklist