Update GPU Whitelist System

[blusewill]

Because too many people says their Laptop goes Brrrrrrr when running winutil

I decided to ban every single Laptop GPU boots into Matrix Mode

Also added some low Powered NVIDIA GPU Such as GT Series.

Sort of*
fixes: #2170
fixes: #2023

[og-mrk]

@blusewill
I've made a PR to your Fork which improves the function overall readability and shortens the length of it, if you're interested in reviewing it, then here's a link to it.

[blusewill]

Alright! Thanks for the Formatting

[Marterich]

First of all, great work both of you :)
Regarding better readability, you could also take a look at replacing the if constructs with a switch case statement using Wildcards
This would reduce the number of times $gpuName needs to be referenced in the code

https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-powershell-1.0/ff730937(v=technet.10)?redirectedfrom=MSDN

Edit: it's also possible to refactor the code to use only a single for each loop which improves performance and readability alike.
I'll see if I create a PR to your branch later today

[og-mrk]

First of all, great work both of you :) Regarding better readability, you could also take a look at replacing the if constructs with a switch case statement using Wildcards This would reduce the number of times $gpuName needs to be referenced in the code

https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-powershell-1.0/ff730937(v=technet.10)?redirectedfrom=MSDN

Thanks for the info @Marterich , checked it out and do see that it may improve the readability of the code.. but I can't figure out a way to do C 's Switch style of Multiple cases (Pattern Matching), one code to execute, like the follow:

switch (x){
  case 1:
  case 2:
  case 3:
  case 4:
  case 5:
  case 6:
      printf ("The number you entered is >= 1 and <= 6\n");
      break;
}

The closest I got is a StackOverFlow Question on this topic.

Edit: it's also possible to refactor the code to use only a single for each loop which improves performance and readability alike. I'll see if I create a PR to your branch later today

... I was about to write how it might be difficult to achieve this (because of *NVIDIA* pattern matching in second ForEach loop).. but after some thinking about it.. it might be easier than I initially thought, I'll leave it to you, but if you want I'll have the code in a section below, based on your idea, which will hopefully work without a problem. (gonna hide it in a Collapsible Section.. to see if you can guess the answer 😉)

Note

The code in next section doesn't use Switch Statement(s), only If Statement(s).. you've to implement the Switch one on your own @Marterich if you want it 👍

The Updated Code

function Invoke-WinUtilGPU {
    $gpuInfo = Get-CimInstance Win32_VideoController
foreach ($gpu in $gpuInfo) {
    $gpuName = $gpu.Name

    # GPUs to blacklist from using Demanding Theming
    if ($gpuName -like "*NVIDIA GeForce*M*" -OR
        $gpuName -like "*NVIDIA GeForce*Laptop*" -OR
        $gpuName -like "*NVIDIA GeForce*GT*" -OR
        $gpuName -like "*AMD Radeon(TM)*" -OR
        $gpuName -like "*UHD*") {
        return $false
    }

    # GPUs to whitelist on using Demanding Theming
    if ($gpuName -like "*NVIDIA*" -OR
        $gpuName -like "*AMD Radeon RX*") {
        return $true
    }
}

}

[Marterich]

@blusewill
I created a PR to your branch containing a refactored version that cleans up the script quite a bit more (IMHO)
If you want to modify something even further, feel free to do so :)
@og-mrk I took inspiration from your code as well while refactoring this

My changes in https://github.com/blusewill/pull/3

• Removed Whitelist part and default to $true if the LowPowerGPUs are not found
• factor out the GPUs into a List to separate the logic from the content. This allows adding new GPUs to the List without modifying the Logic part.
• remove unnecessary variable assignment for $gpuName as this is not used elsewhere

[blusewill]

There is so many long time contributor lol

[Marterich]

@blusewill fyi in case you didn't know
If you edit the PR Description to something like
fixes: #2170
fixes: #2023
it will link the Issues and close them automatically as soon as your PR gets merged :)

[blusewill]

Oh really? That's a thing in Github Action now?

Let me edit it

[Marterich]

Oh really? That's a thing in Github Action now?

Let me edit it

It's actually a GitHub native function
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

[blusewill]

Oh really? That's a thing in Github Action now?
Let me edit it

It's actually a GitHub native function https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Oh really! I didn't know that. Thanks for telling me that.

[ChrisTitusTech]

Great job all