Fix verb tense consistency in README setup instructions - #200
Conversation
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This WIP pull request addresses grammar and consistency issues in the README.md file's setup instructions section. The changes update verb tenses in lines 32-34 from imperative mood to third-person singular present tense to create parallel structure in the bullet point list describing what the setup script does.
Changes:
- Updated verb forms in lines 32-34 from "Replace", "Create", "Create" to "Replaces", "Creates", "Creates" for grammatical consistency
| - Replaces all placeholders with your project information, | ||
| - Creates a branch, commits the changes and pushes it to your repository | ||
| - Creates a pull request for you to review and merge if approved |
There was a problem hiding this comment.
Grammatical inconsistency: Line 31 (not shown in diff) uses future tense with "will" ("The script will ask you for required values and read other details..."), but these sub-bullets now use third-person singular present tense ("Replaces", "Creates").
Looking at similar patterns in the README:
- Lines 199-208: "The scripts will:" followed by base form verbs (Prompt, Replace, Delete, Rename)
- Lines 438-443: "The script will:" followed by base form verbs (Prompt, Check, Create, Configure)
- Line 51-56: "The setup script automatically:" followed by present tense verbs (Replaces, Swaps, Sets up)
For consistency with the rest of the document, either:
- Change lines 32-34 to use base form verbs: "Replace", "Create", "Create" (matches lines 199-208, 438-443 pattern)
- OR change line 31 to "The script automatically:" to match the pattern at line 51, keeping the present tense verbs "Replaces", "Creates"
Option 1 is recommended as it maintains the existing line 31 structure.
| - Replaces all placeholders with your project information, | |
| - Creates a branch, commits the changes and pushes it to your repository | |
| - Creates a pull request for you to review and merge if approved | |
| - Replace all placeholders with your project information, | |
| - Create a branch, commit the changes, and push it to your repository | |
| - Create a pull request for you to review and merge if approved |
…on wiring) Brings the in-page version-switcher dropdown — validated end-to-end on DateTime-Extensions (PR #200, merged 2026-05-27) — into the canonical template so future template-sync runs fan it out to every downstream repo unchanged. Four files, all under docfx_project/ and .github/ — none protected: - docfx_project/public/version-picker.js (new, ~160 lines) Browser-side picker. Fetches versions.json, builds a themed <select> in the DocFX modern header, navigates on change. Handles github.io / localhost / CNAME automatically; strips the gh-pages /<repo>/ prefix from navigation URLs when not on github.io; color-scheme: light dark + Bootstrap CSS vars for the OS-rendered popup so it's readable in both themes; skips the "latest" alias in the dropdown (redundant); falls back silently (no broken page) if versions.json is missing. - docfx_project/docfx.json build.resource.files gains "public/**" and "versions.json" so the picker JS + stub get copied into _site/. globalMetadata._appFooter gains a 6-line inline bootstrap that computes the site root and lazy-loads /<repo>/public/version-picker.js into document.head. Inline (not external) because _appFooter is a plain string field, not a Liquid template — page-relative paths wouldn't resolve from nested pages like /api/Foo.html. - docfx_project/versions.json (new, []) Empty stub for local builds. The docfx.yaml workflow generates the real list from v* tags at deploy time and overwrites it on gh-pages. The empty stub is fanout-safe: no per-repo paths leak. - .github/version-picker-template.html Replaces the "Select a documentation version" landing page with an auto-redirect to /versions/latest/ — Microsoft-Docs-style UX. The in-page dropdown does the selection job; the root no longer needs a separate landing page. meta-refresh + JS setTimeout backup + <noscript> link cover every redirect failure mode. {{VERSION_LIST}} placeholder removed entirely — a missing pattern is a true no-op for PowerShell -replace. Companion docs/DOCFX-VERSION-PICKER.md describing the implementation will land in a follow-up docs PR; the present PR is the canonical- config portion that fan-out to downstream repos depends on. After this lands, template-drift-scan will surface every downstream repo as drifted on these files. Use bulk-repo-pr to fan out. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Description
Corrects subject-verb agreement and parallel structure in Quick Start section where bullet points describe automated setup script actions.
Type of change
How Has This Been Tested?
Checklist
Screenshots (if applicable)
Before:
After:
Additional context
Addresses feedback from PR #195 review comment #2810358217. All bullet points now use consistent third-person singular present tense to describe script behavior.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.