.editorconfig: sync from canonical#96
Merged
Merged
Conversation
Picks up canonical changes since this repo's last .editorconfig sync, including repo-template#329 (RS0030 = none in tests/benchmarks) and repo-template#330 (modern C# style suggestions at suggestion/silent severity). .editorconfig is a protected file; the PR workflow's protected-files guard will fail by design. Requires maintainer admin merge after verifying the diff matches canonical byte-for-byte. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs this repository’s .editorconfig with the current canonical version from the repo template, updating analyzer/style preferences and severities to match the shared standard.
Changes:
- Adds several modern C# style preferences (e.g., using placement, method-group conversion, primary constructors,
System.Threading.Lock) at non-blocking severities. - Adds compound-assignment preference and an operator-wrapping placement preference.
- Adjusts expression-bodied operator preference setting (non-blocking).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs
.editorconfigto current canonical (repo-templatemain).Brings this repo up to date with the canonical changes that landed since the last
.editorconfigsync, including:RS0030.severity = nonein[tests/**/*.cs]and[benchmarks/**/*.cs](the priorwarningsetting was promoted back to error byTreatWarningsAsErrorsin Release).System.Threading.Lock, compound assignment, expression-bodied operators, operator placement when wrapping). All atsuggestion/silentseverity — non-blocking.Expected CI behavior
PR Checks v3 (Gated)→Detect protected configuration file changeswill fail by design..editorconfigis a protected file; the PR workflow gates non-Dependabot changes via that step. CI cannot pass automated checks as-is.Merge path: maintainer manual review + admin merge (or temporary ruleset bypass), after locally verifying the diff matches
repo-template/.editorconfigbyte-for-byte.Test plan
.editorconfigcontent matches canonical byte-for-byte (verified locally withdiffbefore push)repo-template/.editorconfig🤖 Generated with Claude Code