Remove Setup-BranchRuleset.ps1 and Fix-BranchRuleset.ps1 (kept canonical in repo-template)#93
Merged
Merged
Conversation
These are run-once scripts for initial repo setup. They are kept canonical in repo-template only. Once a repo exists, the ruleset state is managed via the GitHub API; keeping copies of the scripts in every repo just creates drift. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Removes the older monolithic [*]+[*.cs] editorconfig style and adopts the canonical structure with per-file-pattern (XML, JSON, YAML, PS1) and per-folder (src, tests, benchmarks, examples) sections. Functional changes: - indent_style: tab -> space - end_of_line: crlf -> lf - Adds per-folder analyzer rule blocks (strict in src/, relaxed in tests/benchmarks/examples) - Drops ReSharper-specific properties (canonical doesn't have them) Existing C# files are not reformatted by this change; they keep their current formatting until a developer saves them and the editor (or a formatter) applies the new rules. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Restores Directory.Build.props to canonical: adds the centralized analyzer ItemGroup (6 packages including Meziantou 3.0.58 and SonarAnalyzer 10.25.0.139117) and the AdditionalFiles entry for BannedSymbols.txt. - Removes duplicate analyzer ItemGroup + per-project AdditionalFiles reference from src/Wolfgang.TryPattern.csproj (now inherited). Other csprojs (tests, benchmarks, 2 examples) had no analyzer refs previously and now pick them up via inheritance. - Refreshes .editorconfig (#325 + #326). - Refreshes pr.yaml (#322 + #323 + #324). - Refreshes docfx.yaml (#327). - Refreshes coverlet.runsettings to canonical. NOTE: This PR's CI will be red until the companion code-fix PR merges. The bumped Meziantou + bumped Sonar + canonical .editorconfig surface 18 violations across src/Wolfgang.TryPattern (CA1000, MA0003, RCS1140, RCS1163). Those are addressed in a separate PR so the drift is reviewable in isolation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
Code-fix split out into a companion PR (CA1000/MA0003/RCS1140/RCS1163 in Result and Try). Merge that first, then this PR will go green after rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes:
scripts/Setup-BranchRuleset.ps1scripts/Fix-BranchRuleset.ps1These are kept canonical only in
repo-templatesince they are run-once at initial repo creation. Once a repo exists, ruleset state is managed via the GitHub API directly — keeping copies of these scripts in every repo just creates drift to maintain.If you ever need to re-create or repair a ruleset, grab the script from
repo-templateor use the API directly.Branch
Named
chore/template-drift-fixesso further drift fixes can be added as additional commits to the same PR.